linux-kernel - Re: [PATCH 2/3] fix warning of not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081206022917.GA7488@ubuntu>
Date:	Sat, 6 Dec 2008 10:29:17 +0800
From:	Jianjun Kong <jianjun@...ux.org>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Linux-Kernel-Mailing-List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/3] fix warning of not used variable

On Sat, Dec 06, 2008 at 12:52:56AM +0000, Américo Wang wrote:
>On Fri, Dec 5, 2008 at 12:01 AM, Rusty Russell <rusty@...tcorp.com.au> wrote:
>> On Thursday 04 December 2008 22:06:33 Américo Wang wrote:
>>> On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@...ux.org> wrote:
>>> > fix this warning:
>>> > kernel/module.c:824: warning: 'print_unload_info' defined but not used
>>> > print_unload_info() just used when CONFIG_PROC_FS was defined.
>>> >
>>> > Signed-off-by: Jianjun Kong <jianjun@...ux.org>
>>>
>>> Reviewed-by: WANG Cong <wangcong@...ux.org>
>>
>> My main concern is that this adds two new #ifdef sections.  How about marking
>> both cases "inline" instead?
>>
>
>Hi, sorry for the delay.
>
>Er, making them inline can solve this problem?

I have make a new patch, and it can compile without any warning :)

---
From: Jianjun Kong <jianjun@...ux.org>
Date: Sat, 6 Dec 2008 10:19:09 +0800
Subject: [PATCH] kernel/module.c: fix compile warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Fix this warning:
kernel/module.c:824: warning: ‘print_unload_info’ defined but not used
print_unload_info() just was used when CONFIG_PROC_FS was defined.
This patch mark print_unload_info() inline to solve the problem.

Signed-off-by: Jianjun Kong <jianjun@...ux.org>
CC: Rusty Russell <rusty@...tcorp.com.au>
CC: Ingo Molnar <mingo@...e.hu>
CC: Américo Wang <xiyou.wangcong@...il.com>
---
 kernel/module.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 1f4cc00..e67f2f8 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -820,7 +820,7 @@ sys_delete_module(const char __user *name_user, unsigned int flags)
 	return ret;
 }
 
-static void print_unload_info(struct seq_file *m, struct module *mod)
+static inline void print_unload_info(struct seq_file *m, struct module *mod)
 {
 	struct module_use *use;
 	int printed_something = 0;
@@ -893,7 +893,7 @@ void module_put(struct module *module)
 EXPORT_SYMBOL(module_put);
 
 #else /* !CONFIG_MODULE_UNLOAD */
-static void print_unload_info(struct seq_file *m, struct module *mod)
+static inline void print_unload_info(struct seq_file *m, struct module *mod)
 {
 	/* We don't know the usage count, or what modules are using. */
 	seq_printf(m, " - -");
-- 
1.5.6.3


-- 
Jianjun Kong | Happy Hacking
HOMEPAGE: http://kongove.cn/
GTALK: kongjianjun@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/