linux-kernel - Re: [trivial] fix missing space in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Dec 2008 13:10:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [trivial] fix missing space in printk


* Michael Tokarev <mjt@....msk.ru> wrote:

> Just come across this when booting on an old hw.. Looks somewhat ugly, 
> that single missing space ;)
> 
> And oh,
> 
> Signed-Off-By: Michael Tokarev <mjt@....msk.ru>
> 
> ;)

applied to tip/x86/cleanups.

> --- a/arch/x86/kernel/smpboot.c	2008-10-10 02:13:53.000000000 +0400
> +++ b/arch/x86/kernel/smpboot.c	2008-12-05 14:39:29.608353301 +0300
> @@ -1084,7 +1084,7 @@ static int __init smp_sanity_check(unsig
>  #endif
>  
>  	if (!physid_isset(hard_smp_processor_id(), phys_cpu_present_map)) {
> -		printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
> +		printk(KERN_WARNING "weird, boot CPU (#%d) not listed "
>  				    "by the BIOS.\n", hard_smp_processor_id());

btw., the reason for that bug was the incorrect line break in the middle 
of a string - we humans just dont notice a missing space in that context. 

So in the final commit i've moved the string to a single line, see it 
attached below.

	Ingo

--------------->
>From 55c395b47042e12d5c25aa07f271f56ffe44f793 Mon Sep 17 00:00:00 2001
From: Michael Tokarev <mjt@....msk.ru>
Date: Fri, 5 Dec 2008 14:42:20 +0300
Subject: [PATCH] x86: fix missing space in printk

Just come across this when booting on an old hw..
Looks somewhat ugly, that single missing space ;)

Signed-off-by: Michael Tokarev <mjt@....msk.ru>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/smpboot.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 7b10933..1a3c325 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1086,8 +1086,10 @@ static int __init smp_sanity_check(unsigned max_cpus)
 #endif
 
 	if (!physid_isset(hard_smp_processor_id(), phys_cpu_present_map)) {
-		printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
-				    "by the BIOS.\n", hard_smp_processor_id());
+		printk(KERN_WARNING
+			"weird, boot CPU (#%d) not listed by the BIOS.\n",
+			hard_smp_processor_id());
+
 		physid_set(hard_smp_processor_id(), phys_cpu_present_map);
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/