linux-kernel - Re: [trivial] fix missing space in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493922E1.4050501@msgid.tls.msk.ru>
Date:	Fri, 05 Dec 2008 15:47:29 +0300
From:	Michael Tokarev <mjt@....msk.ru>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [trivial] fix missing space in printk

Ingo Molnar wrote:
> * Michael Tokarev <mjt@....msk.ru> wrote:
> 
>> Just come across this when booting on an old hw.. Looks somewhat ugly, 
>> that single missing space ;)
>>
>> And oh,
>>
>> Signed-Off-By: Michael Tokarev <mjt@....msk.ru>
>>
>> ;)
> 
> applied to tip/x86/cleanups.
> 
>> --- a/arch/x86/kernel/smpboot.c	2008-10-10 02:13:53.000000000 +0400
>> +++ b/arch/x86/kernel/smpboot.c	2008-12-05 14:39:29.608353301 +0300
>> @@ -1084,7 +1084,7 @@ static int __init smp_sanity_check(unsig
>>  #endif
>>  
>>  	if (!physid_isset(hard_smp_processor_id(), phys_cpu_present_map)) {
>> -		printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
>> +		printk(KERN_WARNING "weird, boot CPU (#%d) not listed "
>>  				    "by the BIOS.\n", hard_smp_processor_id());
> 
> btw., the reason for that bug was the incorrect line break in the middle 
> of a string - we humans just dont notice a missing space in that context. 
> 
> So in the final commit i've moved the string to a single line, see it 
> attached below.

Oh well.  Thanks.  There's another very similar thing in
arch/x86/kernel/pci-dma.c, via_no_dac() (attached).

By the way, where such tiny/trivial things should go?

Thanks!

/mjt

View attachment "viadac.diff" of type "text/x-patch" (474 bytes)