linux-kernel - Re: [trivial] fix missing space in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081205130149.GA15851@elte.hu>
Date:	Fri, 5 Dec 2008 14:01:49 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [trivial] fix missing space in printk


* Michael Tokarev <mjt@....msk.ru> wrote:

> > 
> > btw., the reason for that bug was the incorrect line break in the 
> > middle of a string - we humans just dont notice a missing space in 
> > that context.
> > 
> > So in the final commit i've moved the string to a single line, see it 
> > attached below.
> 
> Oh well.  Thanks.  There's another very similar thing in
> arch/x86/kernel/pci-dma.c, via_no_dac() (attached).

applied - see below. I guess it has your signoff, correct?

> By the way, where such tiny/trivial things should go?

if it touches x86 code, then they can go via the x86 tree.

	Ingo

---------------->
>From a0286c94f07636380082608196d41dd725a83229 Mon Sep 17 00:00:00 2001
From: Michael Tokarev <mjt@....msk.ru>
Date: Fri, 5 Dec 2008 15:47:29 +0300
Subject: [PATCH] x86: fix missing space in printk, #2

Impact: clean up printk

Signed-off-by: Michael Tokarev <mjt@....msk.ru>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/pci-dma.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 1926248..dc57299 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -300,8 +300,8 @@ fs_initcall(pci_iommu_init);
 static __devinit void via_no_dac(struct pci_dev *dev)
 {
 	if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
-		printk(KERN_INFO "PCI: VIA PCI bridge detected."
-				 "Disabling DAC.\n");
+		printk(KERN_INFO
+			"PCI: VIA PCI bridge detected. Disabling DAC.\n");
 		forbid_dac = 1;
 	}
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/