linux-kernel - Re: [patch 011/104] fbdev: clean the penguins dirty feet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081205125855.GA1750@ucw.cz>
Date:	Fri, 5 Dec 2008 13:58:55 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Clemens Ladisch <clemens@...isch.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Krzysztof Helt <krzysztof.h1@...zta.fm>
Subject: Re: [patch 011/104] fbdev: clean the penguins dirty feet


On Wed 2008-12-03 11:48:38, Greg KH wrote:
> 2.6.27-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> From: Clemens Ladisch <clemens@...isch.de>
> 
> commit cf7ee554f3a324e98181b0ea249d9d5be3a0acb8 upstream.
> 
> When booting in a direct color mode, the penguin has dirty feet, i.e.,
> some pixels have the wrong color.  This is caused by
> fb_set_logo_directpalette() which does not initialize the last 32 palette
> entries.

Heh, funny, but... is this really bad enough bug to go to stable?

									Pavel

> Signed-off-by: Clemens Ladisch <clemens@...isch.de>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Krzysztof Helt <krzysztof.h1@...zta.fm>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> ---
>  drivers/video/fbmem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -232,7 +232,7 @@ static void fb_set_logo_directpalette(st
>  	greenshift = info->var.green.offset;
>  	blueshift = info->var.blue.offset;
>  
> -	for (i = 32; i < logo->clutsize; i++)
> +	for (i = 32; i < 32 + logo->clutsize; i++)
>  		palette[i] = i << redshift | i << greenshift | i << blueshift;
>  }
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/