linux-kernel - Re: [PATCH] tty: Flags should be accessed via the foo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081204230823.bdb78508.akpm@linux-foundation.org>
Date:	Thu, 4 Dec 2008 23:08:23 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: Flags should be accessed via the foo_bit
 interfaces

On Thu, 04 Dec 2008 15:41:19 +0000 Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> --- a/drivers/net/slip.c
> +++ b/drivers/net/slip.c
> @@ -432,7 +432,7 @@ static void slip_write_wakeup(struct tty_struct *tty)
>  		/* Now serial buffer is almost free & we can start
>  		 * transmission of another packet */
>  		sl->tx_packets++;
> -		tty->flags &= ~(1 << TTY_DO_WRITE_WAKEUP);
> +		clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags);

that's different.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/