linux-kernel - Re: [W1] List slaves commands.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081208135848.2a529f86.akpm@linux-foundation.org>
Date:	Mon, 8 Dec 2008 13:58:48 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	linux-kernel@...r.kernel.org, frederik.deweerdt@...og.eu,
	randy.dunlap@...cle.com, zbr@...emap.net
Subject: Re: [W1] List slaves commands.

On Fri,  5 Dec 2008 15:41:27 +0300
Evgeniy Polyakov <zbr@...emap.net> wrote:

> +		u64 *data = (void *)(cmd + 1) + cmd->len;
> +
> +		*data = rn;

This code performs quite a lot of potentially unaligned acceses.

Is there anything which guarantees that all these accesses are
well-aligned?

If not, will there be issues with platforms which don't handle
unaligned accesses as well as x86?

Should this code be using the unaligned access interfaces
(get_unaligned, put_unaligned, etc.  Might be wrong.  Keeps changing. 
Harvey Harrison is the guy to ask)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/