lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 9 Dec 2008 01:49:58 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, frederik.deweerdt@...og.eu,
	randy.dunlap@...cle.com
Subject: Re: [W1] List slaves commands.

On Mon, Dec 08, 2008 at 01:58:48PM -0800, Andrew Morton (akpm@...ux-foundation.org) wrote:
> This code performs quite a lot of potentially unaligned acceses.
> 
> Is there anything which guarantees that all these accesses are
> well-aligned?
> 
> If not, will there be issues with platforms which don't handle
> unaligned accesses as well as x86?
> 
> Should this code be using the unaligned access interfaces
> (get_unaligned, put_unaligned, etc.  Might be wrong.  Keeps changing. 
> Harvey Harrison is the guy to ask)?

Every store should be at least 4-bytes aligned because of used headers.
Particular mentioned command is 8-bytes aligned (and all its writes)
as long as others in this patchset (pointer alignment + 40 or 32 bytes
of the headers).

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ