[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081210165455.GC6391@linux.vnet.ibm.com>
Date: Wed, 10 Dec 2008 22:24:55 +0530
From: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
netdev <netdev@...r.kernel.org>, linux-next@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
netfilter-devel@...r.kernel.org, eric@....fr, kaber@...sh.net
Subject: Re: linux-next: Tree for December 1 (netfilter build error)
* Randy Dunlap <randy.dunlap@...cle.com> [2008-12-01 11:59:34]:
> On Mon, 1 Dec 2008 19:08:27 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20081128:
> >
> > Today's tree fails the powerpc allyesconfig build.
>
>
> ERROR: "nfulnl_log_packet" [net/netfilter/xt_NFLOG.ko] undefined!
>
> config attached.
next-20081210 kernel build fails when !CONFIG_NETFILTER_NETLINK_LOG
This was introduced by the
commit 5f7340eff8f68f41b7e5c7ad47ec4cd1ea1afb40
Author: Eric Leblond <eric@....fr>
Date: Tue Nov 4 14:21:08 2008 +0100
netfilter: xt_NFLOG: don't call nf_log_packet in NFLOG module.
the function nfulnl_log_packet is exported only if
CONFIG_NETFILTER_NETLINK_LOG is enabled, so marking the loging function
between ifdef.
I have tested the patch for build failure only
Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
--
net/netfilter/xt_NFLOG.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c
index a57c5cf..fa814a6 100644
--- a/net/netfilter/xt_NFLOG.c
+++ b/net/netfilter/xt_NFLOG.c
@@ -32,8 +32,11 @@ nflog_tg(struct sk_buff *skb, const struct xt_target_param *par)
li.u.ulog.group = info->group;
li.u.ulog.qthreshold = info->threshold;
+#ifdef CONFIG_NETFILTER_NETLINK_LOG
nfulnl_log_packet(par->family, par->hooknum, skb, par->in,
par->out, &li, info->prefix);
+#endif /* CONFIG_NETFILTER_NETLINK_LOG */
+
return XT_CONTINUE;
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists