linux-kernel - Re: linux-next: Tree for December 1 (netfilter build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Dec 2008 19:43:50 +0100
From:	Eric Leblond <eric@....fr>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	netdev <netdev@...r.kernel.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	netfilter-devel@...r.kernel.org, kaber@...sh.net
Subject: Re: linux-next: Tree for December 1 (netfilter build error)

Hi,

Le mercredi 10 décembre 2008 à 22:24 +0530, Kamalesh Babulal a écrit :
> * Randy Dunlap <randy.dunlap@...cle.com> [2008-12-01 11:59:34]:
> 	    
> the function nfulnl_log_packet is exported only if
> CONFIG_NETFILTER_NETLINK_LOG is enabled, so marking the loging function
> between ifdef.
> 

My patch introduces a real depedency of xt_NFLOG with nfnetlink_log
(CONFIG_NETFILTER_NETLINK_LOG) but I forget to state it in Kconfig.
 
I thus disagree with your patch. It is better to fix the compilation
depedency instead by modifying Kconfig.

A patch fixing this issue is to come.

BR, 
-- 
Eric Leblond <eric@....fr>
INL

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)