linux-kernel - Re: [stable] [PATCH] tracehook: exec double-reporting fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Dec 2008 08:44:54 -0800
From:	Greg KH <greg@...ah.com>
To:	Roland McGrath <roland@...hat.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"Ulrich Weigand <ulrich.weigand@...ibm.com>, Oleg Nesterov" 
	<oleg@...sign.ru>, linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, stable@...nel.org
Subject: Re: [stable] [PATCH] tracehook: exec double-reporting fix

On Tue, Dec 09, 2008 at 08:04:23PM -0800, Roland McGrath wrote:
> The following changes since commit 437f2f91d6597c67662f847d9ed4c99cb3c440cd:
>   Linus Torvalds (1):
>         Merge master.kernel.org:/home/rmk/linux-2.6-arm
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git to-linus
> 
> Roland McGrath (1):
>       tracehook: exec double-reporting fix
> 
>  fs/exec.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> 
> Thanks,
> Roland
> ---
> [PATCH] tracehook: exec double-reporting fix
> 
> The patch 6341c39 "tracehook: exec" introduced a small regression in
> 2.6.27 regarding binfmt_misc exec event reporting.  Since the reporting
> is now done in the common search_binary_handler() function, an exec
> of a misc binary will result in two (or possibly multiple) exec events
> being reported, instead of just a single one, because the misc handler
> contains a recursive call to search_binary_handler.

<snip>

Unfortunatly, bprm->recursion_depth was added in 2.6.28-rc1, so this
patch can't easily apply to the 2.6.27.y tree :(

Should I also apply commit id bf2a9a39639b8b51377905397a5005f444e9a892:
	From: Kirill A. Shutemov <kirill@...temov.name>
	Date: Wed, 15 Oct 2008 22:02:39 -0700
	Subject: [PATCH] Allow recursion in binfmt_script and binfmt_misc

To get this one to apply properly?

Hm, in looking at bf2a9a39639b8b51377905397a5005f444e9a892, that seems
like a valid fix for the 2.6.27.y series as well, so perhaps I should do
this anyway.

Any objections to that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/