linux-kernel - Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081211192725.GH18309@ldl.fc.hp.com>
Date:	Thu, 11 Dec 2008 12:27:25 -0700
From:	Alex Chiang <achiang@...com>
To:	Ville Syrjälä <syrjala@....fi>,
	Jesse Barnes <jbarnes@...tuousgeek.org>, justin.chen@...com,
	linux-pci <linux-pci@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN

* Ville Syrjälä <syrjala@....fi>:
> On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote:
> > From: Justin Chen <justin.chen@...com>
> > 
> > Certain HP machines require the full 64 bits of _SUN as allowed
> > by the ACPI spec. Without this change, we get name collisions in
> > the lower 32 bits of the _SUN returned by firmware.
> > 
> > Signed-off-by: Justin Chen <justin.chen@...com>
> > Signed-off-by: Alex Chiang <achiang@...com>
> > ---
> > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> > index f9e244d..9bcb6cb 100644
> > --- a/drivers/pci/hotplug/acpiphp.h
> > +++ b/drivers/pci/hotplug/acpiphp.h
> > @@ -113,7 +113,7 @@ struct acpiphp_slot {
> >  
> >  	u8		device;		/* pci device# */
> >  
> > -	u32		sun;		/* ACPI _SUN (slot unique number) */
> > +	unsigned long long sun;		/* ACPI _SUN (slot unique number) */
> 
> Why not make it u64 if that's what ACPI says it should be?

Some 64-bit architectures typedef u64 to unsigned long, and some
to unsigned long long.

I'd prefer not to have to cast it to a (ULL) every time I want to
printk.

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/