linux-kernel - Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812161047.24759.jbarnes@virtuousgeek.org>
Date:	Tue, 16 Dec 2008 10:47:24 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Alex Chiang <achiang@...com>, justin.chen@...com,
	"linux-pci" <linux-pci@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN

On Thursday, December 11, 2008 11:03 am Matthew Wilcox wrote:
> On Thu, Dec 11, 2008 at 10:35:01AM -0800, Jesse Barnes wrote:
> > On Thursday, December 11, 2008 10:16 am Alex Chiang wrote:
> > > From: Justin Chen <justin.chen@...com>
> > >
> > > Certain HP machines require the full 64 bits of _SUN as allowed
> > > by the ACPI spec. Without this change, we get name collisions in
> > > the lower 32 bits of the _SUN returned by firmware.
> > >
> > > Signed-off-by: Justin Chen <justin.chen@...com>
> > > Signed-off-by: Alex Chiang <achiang@...com>
> >
> > It's very late in the cycle, so I'd like to get acks from at least a
> > couple of other testers for this one...  Any volunteers?
>
> Testers or reviewers?  Here's my review (done thinking out loud style):

Well, review is good too; I stuffed this one into my for-linus branch (the 
whitespace one went into linux-next), thanks for checking it out.

-- 
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/