linux-kernel - Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Dec 2008 21:47:57 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Dave Hansen" <dave@...ux.vnet.ibm.com>
Cc:	"Catalin Marinas" <catalin.marinas@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system_hash

On Thu, 2008-12-11 at 17:38 +0000, Catalin Marinas wrote:
>> Do you mean a comment? I can do this.

On Thu, Dec 11, 2008 at 7:45 PM, Dave Hansen <dave@...ux.vnet.ibm.com> wrote:
> Yeah, something like
>
> /*
>  * kmemleak doesn't actually allocate memory when called this early
>  * so the GFP_ATOMIC here is actually meaningless, but consistent
>  * with the rest of this function.
>  */
>
> Maybe that's too verbose. :)

I'd suggest just doing a separate kmemleak_early_alloc() hook without
the gfp flag.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/