linux-kernel - Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081211122712.aee1f039.akpm@linux-foundation.org>
Date:	Thu, 11 Dec 2008 12:27:12 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	jeff@...zik.org, linux-kernel@...r.kernel.org, jirislaby@...il.com,
	jgarzik@...hat.com, a_romanescu@...oo.co.uk, tj@...nel.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

On Tue,  9 Dec 2008 21:52:28 +0100
Jiri Slaby <jirislaby@...il.com> wrote:

> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
> 
> Check if they are null and avoid checks in that case.
> 
> Solves:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230

This already got fixed, the nasty way.

I queued "DMI: add dmi_match".  We can later switch the piix nastyfix
over to the nicefix as a cleanup.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/