linux-kernel - Re: [PATCH 1/2] DMI: add dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081211122912.58eb164e.akpm@linux-foundation.org>
Date:	Thu, 11 Dec 2008 12:29:12 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	jeff@...zik.org, linux-kernel@...r.kernel.org, jirislaby@...il.com,
	jgarzik@...hat.com, a_romanescu@...oo.co.uk, tj@...nel.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 1/2] DMI: add dmi_match

On Tue,  9 Dec 2008 21:52:27 +0100
Jiri Slaby <jirislaby@...il.com> wrote:

> 
> +/**
> + * dmi_match - compare string to the dmi field (if exists)
> + *
> + * Returns true if requested field equals to str (including NULL).
> + */

Forgot to document the arguments.  If you think it matters. (I don't).

> +static inline bool dmi_match(enum dmi_field f, const char *str)
> +{
> +	const char *info = dmi_get_system_info(f);
> +
> +	if (info == NULL || str == NULL)
> +		return info == str;
> +
> +	return !strcmp(info, str);
> +}
> +

I suspect we'd have thinner kernel if this wasn't inlined.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/