linux-kernel - Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fix taskstats->hiwater

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081216114359.50c83bb6@psychotron.englab.brq.redhat.com>
Date:	Tue, 16 Dec 2008 11:43:59 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Oleg Nesterov <oleg@...hat.com>, balbir@...ux.vnet.ibm.com,
	hugh@...itas.com, jlan@....com, jlim@....com,
	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fix
 taskstats->hiwater_xxx accounting

On Mon, 15 Dec 2008 16:21:48 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> 
> > +#define get_mm_hiwater_rss(mm)	max((mm)->hiwater_rss, get_mm_rss(mm))
> 
> This evaluates its argument thrice.
> 
> > +#define get_mm_hiwater_vm(mm)	max((mm)->hiwater_vm, (mm)->total_vm)
> 
> This evaluates its argument twice.
> 
> 
> was sched.h the appropriate header in which to implement these?  Maybe...
I think it was. There are similar helpers at the same place.
> 
> But they're only ever _used_ in kernel/tsacct.c, so do they actually
> need to be implemented in any .h file?
Yes because my patch (ru_maxrss filling) will be using
get_mm_hiwater_rss() from kernel/exit.c and kernel/sys.c
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/