| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081216103626.GA3964@redhat.com> Date: Tue, 16 Dec 2008 11:36:26 +0100 From: Oleg Nesterov <oleg@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: balbir@...ux.vnet.ibm.com, hugh@...itas.com, jlan@....com, jpirko@...hat.com, jlim@....com, kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fix taskstats->hiwater_xxx accounting On 12/15, Andrew Morton wrote: > > On Fri, 12 Dec 2008 15:05:24 +0100 > Oleg Nesterov <oleg@...hat.com> wrote: > > > +#define get_mm_hiwater_rss(mm) max((mm)->hiwater_rss, get_mm_rss(mm)) > > This evaluates its argument thrice. > > > +#define get_mm_hiwater_vm(mm) max((mm)->hiwater_vm, (mm)->total_vm) > > This evaluates its argument twice. I thought that any user should be careful anyway... OK, agreed, will send the cleanup. > was sched.h the appropriate header in which to implement these? Maybe... Just because I'd like to put them near update_hiwater_xxx() > But they're only ever _used_ in kernel/tsacct.c, so do they actually > need to be implemented in any .h file? Jiri cooks the patch which implements rusage->ru_maxrss accounting, it will use the first helper. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists