linux-kernel - Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fix taskstats->hiwater

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081215162148.87fd38a5.akpm@linux-foundation.org>
Date:	Mon, 15 Dec 2008 16:21:48 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	balbir@...ux.vnet.ibm.com, hugh@...itas.com, jlan@....com,
	jpirko@...hat.com, jlim@....com, kosaki.motohiro@...fujitsu.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fix
 taskstats->hiwater_xxx accounting

On Fri, 12 Dec 2008 15:05:24 +0100
Oleg Nesterov <oleg@...hat.com> wrote:
>

> --- K-28/include/linux/sched.h~HIWATER	2008-12-02 17:12:40.000000000 +0100
> +++ K-28/include/linux/sched.h	2008-12-03 18:17:18.000000000 +0100

grumble

> +#define get_mm_hiwater_rss(mm)	max((mm)->hiwater_rss, get_mm_rss(mm))

This evaluates its argument thrice.

> +#define get_mm_hiwater_vm(mm)	max((mm)->hiwater_vm, (mm)->total_vm)

This evaluates its argument twice.


was sched.h the appropriate header in which to implement these?  Maybe...

But they're only ever _used_ in kernel/tsacct.c, so do they actually
need to be implemented in any .h file?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/