linux-kernel - Re: [Patch 3/3] via-sdmmc: via-sdmmc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812161325.58594.arnd@arndb.de>
Date:	Tue, 16 Dec 2008 13:25:58 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	JosephChan@....com.tw
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch 3/3] via-sdmmc: via-sdmmc.h

On Tuesday 16 December 2008, JosephChan@....com.tw wrote:
> Header file of VIA MSP SD/MMC card reader driver.
> 

The order of your patches is reversed, you add the Kconfig/Makefile
changes last so that the tree stays 'bisectable', i.e. you don't
have a broken build in the middle between your patches.

Since your header file is not an interface but only used in a single
source file, I would also suggest merging it into the main via-sdmmc.c
file, add changing Kconfig/Makefile in the same patch.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/