linux-kernel - RE: [Patch 3/3] via-sdmmc: via-sdmmc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C80EF34A3D2E494DBAF9AC29C7AE4EB808521884@exchtp03.taipei.via.com.tw>
Date:	Wed, 17 Dec 2008 19:14:06 +0800
From:	<JosephChan@....com.tw>
To:	<arnd@...db.de>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: [Patch 3/3] via-sdmmc: via-sdmmc.h

> > 
> 
> The order of your patches is reversed, you add the 
> Kconfig/Makefile changes last so that the tree stays 
> 'bisectable', i.e. you don't have a broken build in the 
> middle between your patches.
> 
> Since your header file is not an interface but only used in a 
> single source file, I would also suggest merging it into the 
> main via-sdmmc.c file, add changing Kconfig/Makefile in the 
> same patch.
> 
> 	Arnd <><
> 

Tks, I'll notice this next time.