linux-kernel - Re: [PATCH 0/8, v3] ensure symlinks are NUL-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Dec 2008 11:03:27 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Duane Griffin <duaneg@...da.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Evgeniy Dushistov <dushistov@...l.ru>
Subject: Re: [PATCH 0/8, v3] ensure symlinks are NUL-terminated

On Tue, 2008-12-16 at 15:51 +0000, Duane Griffin wrote:
> These patches fix potential bugs associated with link target handling by
> NUL-terminating names read from disk.
> 
> This is version 3 of these patches. It fixes the bug, pointed out by Al Viro
> and Evgeniy Dushistov, that i_size was not being validated. In order to
> facilitate this it introduces a helper function for terminating the link name,
> as suggested by Al.

Duane,
I see you left out jfs, so I'm assuming you're letting me handle that
one.  I've push my patch upstream, so it should show up in the -next
tree.

Shaggy

> diffstat:
>  fs/ext2/inode.c          |    7 +++++--
>  fs/ext3/inode.c          |    7 +++++--
>  fs/ext4/inode.c          |    7 +++++--
>  fs/freevxfs/vxfs_inode.c |    4 +++-
>  fs/namei.c               |    7 +++++--
>  fs/sysv/inode.c          |    6 +++++-
>  fs/ufs/inode.c           |    8 ++++++--
>  include/linux/namei.h    |    5 +++++
>  8 files changed, 39 insertions(+), 12 deletions(-)
-- 
David Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/