[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081216193843.GD843@elte.hu>
Date: Tue, 16 Dec 2008 20:38:43 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Janne Kulmala <janne.t.kulmala@....fi>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Subject: Re: x86: Fix HPET for Fujitsu u9200
* Janne Kulmala <janne.t.kulmala@....fi> wrote:
> HPET timer is listed in the ACPI table, but needs a quirk entry in order
> to work. Unfortunately, the quirk code runs after first HPET
> hpet_enable() which has already determined that the timer doesn't work
> (reads 0xFFFFFFFF). This patch allows hpet_enable() to be called again
> after running the quirk code.
>
> Signed-off-by: Janne Kulmala <janne.t.kulmala@....fi>
applied to tip/timers/hpet, thanks Janne!
Venki, is this new hpet force-enable quirk entry generally OK:
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_1,
ich_force_enable_hpet);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_4,
+ ich_force_enable_hpet);
i guess it's OK since we enable hpet on ICH8_1 already. Should we perhaps
convert these quirks somehow to some ">= threshold_version" condition,
instead of having to enumerate everything?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists