linux-kernel - Re: [PATCH] HID: avoid sparse warning in HID_COMPAT_LOAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081216194113.GF12431@fluff.org.uk>
Date:	Tue, 16 Dec 2008 19:41:13 +0000
From:	Ben Dooks <ben-linux@...ff.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Hannes Eder <hannes@...neseder.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] HID: avoid sparse warning in HID_COMPAT_LOAD_DRIVER

On Tue, Dec 16, 2008 at 05:01:38PM +0100, Jiri Kosina wrote:
> On Tue, 16 Dec 2008, Ben Dooks wrote:
> 
> > >  #ifdef CONFIG_HID_COMPAT
> > >  #define HID_COMPAT_LOAD_DRIVER(name)	\
> > > +/* prototype to avoid sparse warning */	\
> > > +extern void hid_compat_##name(void);	\
> > >  void hid_compat_##name(void) { }	\
> > surely this could simply be changed to 'static void 
> > hid_compat_##name(void)' if it is only being defined to be an empty 
> 
> This will cause gcc emit warnings about unused symbols.

sorry, 'static inline void' then.
 
> -- 
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/