linux-kernel - Re: [PATCH 1/2] mqueue ns: move mqueue_mnt into struct ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1229540154.17206.428.camel@nimitz>
Date:	Wed, 17 Dec 2008 10:55:54 -0800
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	Linux Containers <containers@...ts.osdl.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mqueue ns: move mqueue_mnt into struct
	ipc_namespace

On Wed, 2008-12-17 at 12:52 -0600, Serge E. Hallyn wrote:
> > > +void mq_init_ns(struct ipc_namespace *ns) {
> > > +   ns->mq_queues_count  = 0;
> > > +   ns->mq_queues_max    = DFLT_QUEUESMAX;
> > > +   ns->mq_msg_max       = DFLT_MSGMAX;
> > > +   ns->mq_msgsize_max   = DFLT_MSGSIZEMAX;
> > > +   ns->mq_mnt           = mntget(init_ipc_ns.mq_mnt);
> > > +}
> > 
> > Heh, I read that as a structure definition at first!  Could you put
> that
> > bracket on a new line.
> 
> That's actually taken care of in the followup patch - same with
> mq_exit_ns.  Sorry about that.  (Still I'd rather not bother with
> the patch flux to change it just in this patch, since whenever
> I do that I inevitably mess up something else)

Ahh, ok.  I guess it is OK since it is temporary.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/