lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Dec 2008 18:46:36 +0300 From: Cyrill Gorcunov <gorcunov@...il.com> To: David Miller <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org> Cc: Pavel Emelyanov <xemul@...nvz.org>, NKML <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Paul Mackerras <paulus@...ba.org> Subject: [PATCH] net: ppp_generic - use DEFINE_IDR for static initialization Please review. --- >From 17bbdd601fc1be761876165488879def4649c968 Mon Sep 17 00:00:00 2001 From: Cyrill Gorcunov <gorcunov@...nvz.org> Date: Thu, 18 Dec 2008 18:41:42 +0300 Subject: [PATCH] net: ppp_generic - use DEFINE_IDR for static initialization We could use DEFINE_IDR for statically allocated idr that allow us to save a few lines of code. And spell fix. CC: Andrew Morton <akpm@...ux-foundation.org> CC: David Miller <davem@...emloft.net> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org> --- drivers/net/ppp_generic.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index 293e1c4..b13e600 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c @@ -178,7 +178,7 @@ struct channel { */ static DEFINE_MUTEX(all_ppp_mutex); static atomic_t ppp_unit_count = ATOMIC_INIT(0); -static struct idr ppp_units_idr; +static DEFINE_IDR(ppp_units_idr); /* * all_channels_lock protects all_channels and last_channel_index, @@ -841,8 +841,6 @@ static int __init ppp_init(void) device_create(ppp_class, NULL, MKDEV(PPP_MAJOR, 0), "ppp"); } - idr_init(&ppp_units_idr); - out: if (err) printk(KERN_ERR "failed to register PPP device (%d)\n", err); @@ -2426,7 +2424,7 @@ ppp_create_interface(int unit, int *retp) if (unit_find(&ppp_units_idr, unit)) goto out2; /* unit already exists */ else { - /* darn, someone is cheatting us? */ + /* darn, someone is cheating us? */ *retp = -EINVAL; goto out2; } -- 1.6.0.4.603.gbc9c0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists