linux-kernel - Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081218112928.6165.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Thu, 18 Dec 2008 11:32:15 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, hch@...radead.org
Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

> sys_execve and sys_uselib do not call into fsnotify so inotify does not get
> open events for these types of syscalls.  This patch simply makes the
> requisite fsnotify calls.
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>

I hope append your latter explain into the patch description.

> I could be convinced to change it but like what I have.  At this point
> the file is open.  If it fails after this we are going to call fput()
> which calls __fput() which calls fsnotify_close().  Seemed odd to leave
> a close without an open (although that's what we have today.)
> 
> This doesn't mean the syscall was successful, but the file was opened,
> and it will be closed....

I think open/close pairing is important thing to this patch.


Otherthings, looks good to me. very thanks.
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/