linux-kernel - Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081218113729.6168.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Thu, 18 Dec 2008 11:39:23 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	kosaki.motohiro@...fujitsu.com, Eric Paris <eparis@...hat.com>,
	linux-kernel@...r.kernel.org, hch@...radead.org
Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify

> On Wed, 17 Dec 2008 13:53:20 -0500
> Eric Paris <eparis@...hat.com> wrote:
> 
> > sys_execve and sys_uselib do not call into fsnotify so inotify does not get
> > open events for these types of syscalls.  This patch simply makes the
> > requisite fsnotify calls.
> 
> These two functions are grovelling around in pretty low-level fs
> operations.  One wonders whether they could be converted (ie: cleaned
> up) to use do_sys_open() or some other such higher-level thing.
> 
> That way, this fsnotify bug would be magically fixed, too.

hmm..

In current implementaion, do_sys_open() call fd_install().
then, it cause /proc/{pid}/fd entry change. iow, compatibility break.

Yup, it is fixable. but I think Eric's implementation is simpler.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/