linux-kernel - Re: [git pull] x86 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081220193106.GA19555@elte.hu>
Date:	Sat, 20 Dec 2008 20:31:06 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Joerg Roedel <joerg.roedel@....com>
Subject: Re: [git pull] x86 fixes

* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Sat, 20 Dec 2008, Ingo Molnar wrote:
> > 
> > Joerg Roedel (3):
> >       AMD IOMMU: panic if completion wait loop fails
> 
> What's the advantage to this, especially this late in the game?
> 
> Now, I tried to google for the message (while ignoring the patches), and 
> as far as I can tell, it has never happened that google has noticed. But 
> still, why was this pushed as a "fix"?

You are right, this patch should have been delayed to .29. Should i rebase 
the branch?

Joerg has been doing stress-tests of the iommu driver and these fixes are 
the result of that. I pulled three patches from Joerg in one group, and 
the other two were real fixes - and this one looked indeed unnecessary but 
harmless, so i didnt ask him to rebase. CONFIG_AMD_IOMMU is default-off 
and a relatively new driver, and the patch came from the hw vendor 
affected by it so i let it through. When i pulled i assumed i could get it 
in before -rc9 but once you released -rc9 the pull was done already. I 
wouldnt have pulled such a patch so close before final .28. The timing was 
a bit unfortunate - can rebase and re-test. Same deal for:

   55aab5f: x86 gart: don't complain if no AMD GART found

i wouldnt have put it in after the final -rc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/