linux-kernel - Re: [PATCH] musb: fix DaVinci build again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812231707.48195.david-b@pacbell.net>
Date:	Tue, 23 Dec 2008 17:07:47 -0800
From:	David Brownell <david-b@...bell.net>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>, gregkh@...e.de,
	felipe.balbi@...ia.com
Cc:	linux-usb@...r.kernel.org, khilman@...prootsystems.com,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] musb: fix DaVinci build again

On Tuesday 23 December 2008, Sergei Shtylyov wrote:
> > Yeah, I sent a DaVinci build fix patch in plenty of time to
> > be merged for *2.6.27* (!!!!) but still the key parts are
> > missing, and have not managed to make it into mainline.
> 
>   Try breakinjg the patches into smaller pieces next time, so they may 
> get thru the maintainer's sieve more easily. :-)

That wasn't the issue back then.  If you look at

  c767c1c6f1febbd1351cc152bba6e37889322d17

which got merged after 2.6.27 shipped, you'll notice that
someone stripped out the following parts from the original
patch, which were even referenced in the patch comment.

This worked as submitted, but then got broken during merge;
and fixes have been re-sent several times already.

Plus, some other stuff has merged which prevents linking.
Fixes for those parts have been re-sent several times too.

- Dave

============= CUT HERE
From: David Brownell <dbrownell@...rs.sourceforge.net>

Build fixes that somehow got stripped out of the earlier build
fix patch ...

Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
---
 drivers/usb/musb/davinci.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -31,10 +31,11 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/gpio.h>
+
+#include <mach/hardware.h>
+#include <mach/memory.h>
 
-#include <asm/arch/hardware.h>
-#include <asm/arch/memory.h>
-#include <asm/arch/gpio.h>
 #include <asm/mach-types.h>
 
 #include "musb_core.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/