linux-kernel - Re: [PATCH] musb: fix DaVinci build again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Dec 2008 04:27:59 +0200
From:	Felipe Balbi <me@...ipebalbi.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>, gregkh@...e.de,
	felipe.balbi@...ia.com,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] musb: fix DaVinci build again

Hi,

just a note before a comment. I'm gonna be on vacations during this and
next week. Trying to get better from a really terrible flu so I won't be
hacking too much during this time.

Anyways, once comment below.

On Tue, Dec 23, 2008 at 05:07:47PM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Build fixes that somehow got stripped out of the earlier build
> fix patch ...
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> ---
>  drivers/usb/musb/davinci.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> --- a/drivers/usb/musb/davinci.c
> +++ b/drivers/usb/musb/davinci.c
> @@ -31,10 +31,11 @@
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/gpio.h>
> +#include <linux/gpio.h>

you're including <linux/gpio.h> twice.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/