linux-kernel - Re: [PATCH, RESEND3] getrusage: fill ru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081225011103.3a81c19d@psychotron.englab.brq.redhat.com>
Date:	Thu, 25 Dec 2008 01:11:03 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	linux-kernel@...r.kernel.org, Hugh Dickins <hugh@...itas.com>
Subject: Re: [PATCH, RESEND3] getrusage: fill ru_maxrss value

On Wed, 24 Dec 2008 18:42:48 +0100
Oleg Nesterov <oleg@...hat.com> wrote:


> > > and we need good comment. e.g. /* Convert to KB */
> > > or good macros (likely linux/fs/proc/meminfo.c::K() macro)
> 
> Yes! Please ;) I just can't parse the code above, I am not compiler.
> Even
> 
> 	r->ru_maxrss *= (PAGE_SIZE / 1024); /* convert pages to KBs */
> 
> is much better, imho. Or at least just add the comment, so the
> poor reader can understand what the code does without parsing.
Fine
> 
> > > In addision, you also need change man pages and notice to linux-api mailing list.
> > I cc'ed this list while I was sending the patch.
> 
> Hmm. The biggest mistake with this patch is that you lost the
> CC list completely ;) Adding Hugh.
> 
> > I was not aware I
> > should change the man page. Will do that too.
> 
> Well. I don't think you must change the man page. Of course it
> would be nice if you do, but in a separate patch please. But
> you must cc Michael at least ;)
I cc'ed him with in my patch post - It has disappeared later in RE. 
> 
> Oleg.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/