linux-kernel - Re: [PATCH] x86 byteorder.h: use __asm__/__inline_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <495680A7.2010900@zytor.com>
Date:	Sat, 27 Dec 2008 11:23:19 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...e.hu>,
	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace

Mike Frysinger wrote:
> 
> {su}{8,16,32,64} doesnt matter too much to me vs {u,}int_t{8,16,32,64}_t.  as 
> long as people stop using __{su}{8,16,32,64}.  using the latter though does 
> mean headers will more likely be "just usable" w/out needing linux/types.h 
> include.  but then people would be forced to include stdint.h or similar 
> before a linux header ... and that sucks.
> 

That is a total non-starter.  This would mean that the C library itself
cannot use these headers without exporting additional symbols into the
namespace, *WHICH IT IS NOT ALLOWED TO DO*.

> unless of course we start adding appropriate C library includes for 
> !__KERNEL__ ... i'd love that personally
> 
>> and bool into the appropriate __{su}{8,16,32,64}
>> types and _Bool.
> 
> i dont get your bool comment.  the "bool" type is already a standard type.  
> there is no conversion needed.

Only if <stdbool.h> is included.  Again, see previous statement.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/