linux-kernel - Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081229125921.GB23674@elte.hu>
Date:	Mon, 29 Dec 2008 13:59:21 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Jaswinder Singh Rajput <jaswinder@...radead.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, mj@....cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to
	arch/x86/include/asm/pci_x86.h


* Sam Ravnborg <sam@...nborg.org> wrote:

> > 
> > btw., you missed to update a couple of places - pci/pci.h was used outside 
> > of arch/x86 as well. Updated patch below.
> > 
> > 	Ingo
> > 
> > ---------------->
> > >From 54a090abe7cb85c724305124f57d2570b7e9adf1 Mon Sep 17 00:00:00 2001
> > From: Jaswinder Singh Rajput <jaswinder@...radead.org>
> > Date: Sat, 27 Dec 2008 18:32:28 +0530
> > Subject: [PATCH] x86, pci: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
> > 
> > Impact: cleanup
> > 
> > Now that arch/x86/pci/pci.h is used in a number of other places as well,
> > move the lowlevel x86 pci definitions into the architecture include files.
> > (not to be confused with the existing arch/x86/include/asm/pci.h file,
> > which provides public details about x86 PCI)
> > 
> > Tested on: X86_32_UP, X86_32_SMP and X86_64_SMP
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > ---
> >  arch/x86/include/asm/pci_x86.h     |  165 ++++++++++++++++++++++++++++++++++++
> >  arch/x86/kernel/mmconf-fam10h_64.c |    3 +-
> >  arch/x86/kernel/reboot.c           |    3 +-
> >  arch/x86/pci/acpi.c                |    2 +-
> >  arch/x86/pci/amd_bus.c             |    2 +-
> >  arch/x86/pci/common.c              |    3 +-
> >  arch/x86/pci/direct.c              |    2 +-
> >  arch/x86/pci/early.c               |    2 +-
> >  arch/x86/pci/fixup.c               |    3 +-
> >  arch/x86/pci/i386.c                |    2 +-
> >  arch/x86/pci/init.c                |    2 +-
> >  arch/x86/pci/irq.c                 |    3 +-
> >  arch/x86/pci/legacy.c              |    2 +-
> >  arch/x86/pci/mmconfig-shared.c     |    3 +-
> >  arch/x86/pci/mmconfig_32.c         |    2 +-
> >  arch/x86/pci/mmconfig_64.c         |    3 +-
> >  arch/x86/pci/numaq_32.c            |    2 +-
> >  arch/x86/pci/olpc.c                |    2 +-
> >  arch/x86/pci/pcbios.c              |    5 +-
> >  arch/x86/pci/pci.h                 |  162 -----------------------------------
> >  arch/x86/pci/visws.c               |    3 +-
> >  drivers/pci/hotplug/cpqphp_core.c  |    2 +-
> >  drivers/pci/hotplug/cpqphp_pci.c   |    2 +-
> >  drivers/pci/hotplug/ibmphp_core.c  |    2 +-
> >  24 files changed, 188 insertions(+), 194 deletions(-)
> 
> You should teach your script to use:
> git format-patch -M -B -C 
> 
> With -M -B -C you get a much better picture of what happens when you 
> rename files like in this patch (and copy them).

you mean:

  git format-patch --stdout -1 -M -B -C <sha1>

(otherwise people trying this out will be faced with git creating all 
commits way back to the beginnings of time, as patches in their current 
directory ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/