linux-kernel - Re: [PATCH 2/2] parisc: fix module loading failure of large modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49590F58.9040909@gmx.de>
Date:	Mon, 29 Dec 2008 18:56:40 +0100
From:	Helge Deller <deller@....de>
To:	John David Anglin <dave@...uly1.hia.nrc.ca>
CC:	linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kyle@...artin.ca, randolph@...sq.org, jmm@...til.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	Helge Deller <deller@....de>
Subject: Re: [PATCH 2/2] parisc: fix module loading failure of large modules

John David Anglin wrote:
> Hi Helge,
> 
>> With this patch we now instead append individual PLT stub entries
>> directly at the end of the code sections where the stubs are actually
>> called. This reduces the distance between the PCREL location and the
>> stub entry so that the relocations can be fulfilled.
> 
> GCC for PA-RISC assumes that the stubs will be placed before the code
> section.  This is what HP-UX does.  It's also not possible to compute
> the distance to the end of a function in GCC due to the way branch
> shortening is done.  If the distance to the start of the code section
> is too large, GCC outputs a long call.

Interesting. I didn't knew that.

> If you can insert them before the code section where the stubs are
> called, this will minimize the chance that a pc-relative call will
> not reach its stub.

Yes, good idea.
I'll change that and send an updated patch.

> Great patch!

Thanks!

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/