linux-kernel - Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken on big-endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4961241C.5020503@s5r6.in-berlin.de>
Date:	Sun, 04 Jan 2009 22:03:24 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Bill Fink <billfink@...dspring.com>
CC:	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken
 on big-endian

Bill Fink wrote:
> Although I admit to being mystified how it works both
> before and after the patch, since the cpu_to_le32() calls that were
> added should result in byte swapping on PPC that wasn't being done
> before.  I guess that either the code paths involved aren't actually
> being triggered by my xine DV viewing, or there's some fortuitous
> palindromic setting of bits.

I agree.  If I had more spare time for these things I would try to find
out what's really going on.  But since the patch really looks like the
right thing to do and doesn't regress, I will send it in without further
investigation.
-- 
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/