linux-kernel - Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken on big-endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Jan 2009 21:18:43 -0500
From:	Bill Fink <billfink@...dspring.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling
 broken on big-endian

On Sat, 03 Jan 2009, Stefan Richter wrote:

> Bill Fink wrote on 2008-12-26:
> > Good news.  I finally got a chance to test the patch on my kernel,
> > and live DV viewing using xine still worked fine.
> 
> Thanks a lot.  If you don't mind, I'll add "Tested-by: Bill Fink
> <billfink@...dspring.com>" to the changelog when I enqueue this for
> Linus, and add a note that it actually worked for you before as well as
> after this patch.

That's fine.  Although I admit to being mystified how it works both
before and after the patch, since the cpu_to_le32() calls that were
added should result in byte swapping on PPC that wasn't being done
before.  I guess that either the code paths involved aren't actually
being triggered by my xine DV viewing, or there's some fortuitous
palindromic setting of bits.

						-Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/