linux-kernel - Re: [PATCH] mflash linux support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090105174026.GA1855@infradead.org>
Date:	Mon, 5 Jan 2009 12:40:26 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Heikki Orsila <shdl@...alwe.fi>, unsik Kim <donari75@...il.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] mflash linux support

On Mon, Jan 05, 2009 at 11:13:21AM +0000, Alan Cox wrote:
> On Mon, 5 Jan 2009 04:33:46 +0200
> Heikki Orsila <shdl@...alwe.fi> wrote:
> 
> > A few style issues:
> 
> How about starting by worrying about the code not pointless style
> complaints ?
> 
> >> > +	switch (cmd) {
> > > +	case HDIO_GETGEO:
> > 
> > 	if (cmd == HDIO_GETGEO) {
> 
> Especially when you are making pointless complaints about things that are
> generally done the way the original code is - and for good reason. It
> makes it far cleaner to add new ioctl support.

Or either of you could check what blkdev_ioctl() does with HDIO_GETGEO
and why this code doesn't even need to exist at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/