linux-kernel - Re: [PATCH] mflash linux support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090105111321.7d210c01@lxorguk.ukuu.org.uk>
Date:	Mon, 5 Jan 2009 11:13:21 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Heikki Orsila <shdl@...alwe.fi>
Cc:	unsik Kim <donari75@...il.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] mflash linux support

On Mon, 5 Jan 2009 04:33:46 +0200
Heikki Orsila <shdl@...alwe.fi> wrote:

> A few style issues:

How about starting by worrying about the code not pointless style
complaints ?

>> > +	switch (cmd) {
> > +	case HDIO_GETGEO:
> 
> 	if (cmd == HDIO_GETGEO) {

Especially when you are making pointless complaints about things that are
generally done the way the original code is - and for good reason. It
makes it far cleaner to add new ioctl support.


It would be interesting to see what mflash looked like as a libata driver
but I think for embedded systems the driver as submitted shows great
promise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/