linux-kernel - Re: [PATCH -tip] x86: setup.c fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f9a31f40901060207j24c580cfl1e8bc71ae486a4b9@mail.gmail.com>
Date:	Tue, 6 Jan 2009 15:37:10 +0530
From:	"Jaswinder Singh Rajput" <jaswinderlinux@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Jaswinder Singh Rajput" <jaswinder@...radead.org>,
	"x86 maintainers" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: setup.c fix style problems

On Sun, Jan 4, 2009 at 10:51 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> the x86-local declarations in smp.h should probably be moved into a
> separate smp_x86.h file - to avoid such trouble.
>

I think we do not need to make any new files only thing we need is to
rearrange stuff between existing files.

Currently there is no such protocol, If we follow this logic then it
will very easy for us to maintain things:

CONFIG_SMP -> asm/smp.h
CONFIG_X86_LOCAL_APIC -> asm/apic.h
CONFIG_X86_IO_APIC -> asm/io_apic.h

And if you want then I will give strict instructions so that we will
never face these problems again, like :-

asm/smp.h:

#ifndef CONFIG_SMP
#error "Including wrong file, why you need smp.h for Uniprocessor"
#else
...
#endif

Similarly for asm/apic.h and asm/io_apic.h

--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/