linux-kernel - Re: [git pull] device-mapper patches for 2.6.29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <496347AC.5000203@s5r6.in-berlin.de>
Date:	Tue, 06 Jan 2009 12:59:40 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	"Cheng Renquan (程任全)" <crquan@...il.com>
CC:	Alasdair G Kergon <agk@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	dm-devel@...hat.com, linux-kernel@...r.kernel.org,
	Jonathan Brassow <jbrassow@...hat.com>,
	Mikulas Patocka <mpatocka@...hat.com>,
	Milan Broz <mbroz@...hat.com>, Andi Kleen <ak@...e.de>,
	Jun'ichi Nomura <j-nomura@...jp.nec.com>,
	Kiyoshi Ueda <k-ueda@...jp.nec.com>,
	Takahiro Yasui <tyasui@...hat.com>
Subject: Re: [git pull] device-mapper patches for 2.6.29

Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@...hat.com> wrote:
>> On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
>>> So now maybe we can add a null macro to module_refcount if
>>> CONFIG_MODULE_UNLOAD undefined?
>>
>> Do we even need the test at all?
> 
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?

The fact that module_refcount may be undefined is an indicator that this
is not an API for general use.

Why are you wanting to peek into the reference count of a module?
Shouldn't you have everything covered by properly recounting all your
data objects?  (Preferably via the kref API.)
-- 
Stefan Richter
-=====-==--= ---= --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/