lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090106034845.GD3512@agk.fab.redhat.com>
Date:	Tue, 6 Jan 2009 03:48:45 +0000
From:	Alasdair G Kergon <agk@...hat.com>
To:	crquan@...il.com
Cc:	Kiyoshi Ueda <k-ueda@...jp.nec.com>, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>,
	Mikulas Patocka <mpatocka@...hat.com>,
	device-mapper development <dm-devel@...hat.com>,
	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Milan Broz <mbroz@...hat.com>
Subject: Re: [dm-devel] Re: [git pull] device-mapper patches for 2.6.29

On Tue, Jan 06, 2009 at 11:32:51AM +0800, Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@...hat.com> wrote:
> > On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
> >> So now maybe we can add a null macro to module_refcount if
> >> CONFIG_MODULE_UNLOAD undefined?
> > Do we even need the test at all?
 
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?
 
I mean under what set of circumstances could the test of the module refcount
here fail, and if the test was simply removed are there any cases where that
would matter?

Alasdair
-- 
agk@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ