linux-kernel - Re: powerpc: introduce asm/swab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0901062354030.26118@xanadu.home>
Date:	Tue, 06 Jan 2009 23:59:16 -0500 (EST)
From:	Nicolas Pitre <nico@....org>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: powerpc: introduce asm/swab.h

On Tue, 6 Jan 2009, Harvey Harrison wrote:

> On Wed, 2009-01-07 at 15:42 +1100, Benjamin Herrenschmidt wrote:
> > On Wed, 2009-01-07 at 04:00 +0000, Linux Kernel Mailing List wrote:
> > > Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=156ca2bbf6503a02d7d6829886ce381d572de66e
> > > Commit:     156ca2bbf6503a02d7d6829886ce381d572de66e
> > > Parent:     8cdd3a9261e8efe36aeb6c708edb76d7e2b5d13f
> > > Author:     Harvey Harrison <harvey.harrison@...il.com>
> > > AuthorDate: Tue Jan 6 14:56:23 2009 -0800
> > > Committer:  Linus Torvalds <torvalds@...ux-foundation.org>
> > > CommitDate: Tue Jan 6 18:10:27 2009 -0800
> > > 
> > >     powerpc: introduce asm/swab.h
> > >     
> > >     Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > >     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > 
> > Was this tested ? I see no arch maintainer signed-off here, it appears
> > to at least break ppc32, and contains hunks that paulus says were
> > explicitely nacked (removing of our ld_* macros) etc...
> > 
> > Linus, please revert.
> 
> Please look a bit closer, it's a pure movement of code out of byteorder.h into swab.h,
> no changes whatsoever.

Well, this series breaks ARM as well:

In file included from include/linux/byteorder/little_endian.h:12,
                 from arch/arm/include/asm/byteorder.h:23,
                 from include/linux/kernel.h:20,
                 from include/linux/sched.h:52,
                 from arch/arm/kernel/asm-offsets.c:13:
include/linux/swab.h: In function '__fswab64':
include/linux/swab.h:71: error: implicit declaration of function '___swab32'


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/