linux-kernel - Re: [PATCH] ring_buffer: fix ring_buffer_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090108144046.GB18120@elte.hu>
Date:	Thu, 8 Jan 2009 15:40:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Robert Richter <robert.richter@....com>,
	Frédéric Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] ring_buffer: fix ring_buffer_event_length()


* Steven Rostedt <rostedt@...dmis.org> wrote:

> 
> On Thu, 8 Jan 2009, Ingo Molnar wrote:
> > 
> > That is a pretty useless duplication of the subject line, so i dropped it. 
> > When the subject line explains the practical impact already, there's no 
> > need to add the impact line.
> 
> Actually, Frederic and I had a discussion about a duplicate Impact line. 
> Perhaps someone is searching the git log on "Impact:" looking for all 
> fixes. Perhaps just a simple:
> 
> Impact: fix
> 
> would be sufficient?

hm, okay - but it should be somewhat different. The impact line should 
really be a 'description of impact/risk'. That overlaps subject lines some 
of the time - but often not. So we could do something more specific like:

  Impact: change/fix (unused) ring-buffer API to be more useful

(For future commits.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/