linux-kernel - Re: [PATCH] x86: mpparse.c fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f9a31f40901080643i4a355168gcdf12ea706c34e3b@mail.gmail.com>
Date:	Thu, 8 Jan 2009 20:13:38 +0530
From:	"Jaswinder Singh Rajput" <jaswinderlinux@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Jaswinder Singh Rajput" <jaswinder@...radead.org>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"x86 maintainers" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: mpparse.c fix style problems

Hello Ingo,

On Sun, Jan 4, 2009 at 10:53 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Jaswinder Singh Rajput <jaswinderlinux@...il.com> wrote:
>
>>
>> Currently I rename fields of few mpc_X structures from
>> arch/x86/include/asm/mpspec_def.h. In this file struct
>> intel_mp_floating is still remaining with mpf_X fields, Is this also
>> need to be fixed ? if yes then mpf_intel name is OK ?
>>

I send :
[PATCH -tip 1/2] x86: rename intel_mp_floating to mpf_intel
[PATCH -tip 2/2] x86: rename all fields of mpf_intel mpf_X to X

Is this OK ?

>> Similarly in arch/x86/include/asm/io_apic.h :
>> 1. struct mp_config_ioapic with mp_X fields (what name will be best ?)
>> 2. struct mp_config_intsrc with mp_X fields
>>
>> These are also used in arch/x86/kernel/mpparse.c
>>
>> Please let me know should I fix mp_X things first or should I proceed
>> further in mpparse.c as per your suggestions.
>
> i think those should be standardized to mpc_X too, and the fields should
> lose their mp_ prefix.
>

struct mpc_ioapic and struct mpc_intsrc is based on MultiProcessor
Specification Version 1.4

But I am not able to find the specification Manual of:

struct mp_config_ioapic and struct mp_config_intsrc.
(arch/x86/include/asm/io_apic.h)

Can you please point me out why the fields of struct mp_config_ioapic
and struct mp_config_intsrc are different from MultiProcessor
Specification Version 1.4

Thanks
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/