linux-kernel - Re: [PATCH] libata: use WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49673D02.6000002@garzik.org>
Date:	Fri, 09 Jan 2009 07:03:14 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Zdenek Kabelac <zdenek.kabelac@...il.com>
CC:	Tejun Heo <tj@...nel.org>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeff Garzik <jgarzik@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] libata: use WARN_ON_ONCE on hot paths

Zdenek Kabelac wrote:
> 2009/1/9 Tejun Heo <tj@...nel.org>:
>> Convert WARN_ON() on command issue/completion paths to WARN_ON_ONCE()
>> so that libata doesn't spam the machine even when one of those
>> conditions triggers repeatedly.
>>
> 
> 
> Hi
> 
> I've not yet applied this patch - but now I'm getting these WARNS on my T61:
> (commit: 2150edc6c5cf00f7adb54538b9ea2a3e9cedca3f)
> 
> Is this patch solving the problem or just hiding warnings ?

Hiding warnings.  As Tejun noted in another email, this condition should 
not be happening in the first place.

If I had to guess, I would say that Arjan's patches assume it is OK to 
treat two ports on a single IDE controller as completely independent, 
when that is not really the reality of the hardware.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/