linux-kernel - Re: [PATCH] libata: use WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090109120730.5c80fc68@lxorguk.ukuu.org.uk>
Date:	Fri, 9 Jan 2009 12:07:30 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Zdenek Kabelac <zdenek.kabelac@...il.com>,
	Tejun Heo <tj@...nel.org>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeff Garzik <jgarzik@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] libata: use WARN_ON_ONCE on hot paths

> If I had to guess, I would say that Arjan's patches assume it is OK to 
> treat two ports on a single IDE controller as completely independent, 
> when that is not really the reality of the hardware.

The PCI probe paths and the setup paths of several of the PATA
controller drivers know they are single threaded in a few spots so it
wouldn't suprise me in the slightest. Really this async stuff needs to
spend 2 or 3 months in -next getting the kinks worked out so that driver
assumptions can be pinned down and fixed, and someone can give it an API
with names that anyone but Arjan understands ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/