linux-kernel - Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090109141642.61540741.akpm@linux-foundation.org>
Date:	Fri, 9 Jan 2009 14:16:42 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	kobayashi.kk@...s.nec.co.jp, kosaki.motohiro@...fujitsu.com,
	linux-kernel@...r.kernel.org, h-shimamoto@...jp.nec.com
Subject: Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc

On Wed, 26 Nov 2008 19:10:28 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> nit
> 
> > @@ -49,6 +50,10 @@ static int show_stat(struct seq_file *p, void *v)
> >  			sum += kstat_irqs_cpu(j, i);
> >  
> >  		sum += arch_irq_stat_cpu(i);
> > +
> > +		for (j = 0; j < NR_SOFTIRQS; j++)
> > +			sum_softirq += kstat_softirqs_cpu(j, i);
> > +
> >  	}
> 
> You can calcurate per_irq_sum here.
> Typically, # of possible cpu are very big.
> 
> So, I don't like unnecessary twrice looping.

I was about to send these patches to Linus, but it seems that this
optmisation hasn't been addressed?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/