linux-kernel - Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51c5bc110901101022g1fc407f6ifc37aa93580a2da1@mail.gmail.com>
Date:	Sat, 10 Jan 2009 10:22:25 -0800
From:	kobayashi.kk@...s.nec.co.jp
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	linux-kernel@...r.kernel.org, h-shimamoto@...jp.nec.com
Subject: Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc

2009/1/9 Andrew Morton <akpm@...ux-foundation.org>:
> On Wed, 26 Nov 2008 19:10:28 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
>
>> nit
>>
>> > @@ -49,6 +50,10 @@ static int show_stat(struct seq_file *p, void *v)
>> >                     sum += kstat_irqs_cpu(j, i);
>> >
>> >             sum += arch_irq_stat_cpu(i);
>> > +
>> > +           for (j = 0; j < NR_SOFTIRQS; j++)
>> > +                   sum_softirq += kstat_softirqs_cpu(j, i);
>> > +
>> >     }
>>
>> You can calcurate per_irq_sum here.
>> Typically, # of possible cpu are very big.
>>
>> So, I don't like unnecessary twrice looping.
>
> I was about to send these patches to Linus, but it seems that this
> optmisation hasn't been addressed?

Thanks for your notice, Andrew.
Of course, thanks for your advice, Kosaki-san.
I didn't check carefully about this point...

Now I am on a business trip.
So, I'll post the fix next week.

// Keika Kobayashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/