linux-kernel - Re: [PATCH 5/5] Fix dubious bitwise 'and' usage spotted by sparse.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 10 Jan 2009 09:47:15 +0000
From:	"Tom Spink" <tspink@...il.com>
To:	"Alexey Zaytsev" <alexey.zaytsev@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Jiri Kosina" <jkosina@...e.cz>,
	"Trivial Kernel Patches" <trivial@...nel.org>
Subject: Re: [PATCH 5/5] Fix dubious bitwise 'and' usage spotted by sparse.

2009/1/9 Alexey Zaytsev <alexey.zaytsev@...il.com>:
> It doesn't change the semantics, but clearly
> the logical 'and' was meant to be used here.
>
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@...il.com>
> ---
>  drivers/usb/wusbcore/security.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/wusbcore/security.c b/drivers/usb/wusbcore/security.c
> index a101cad..8f953ab 100644
> --- a/drivers/usb/wusbcore/security.c
> +++ b/drivers/usb/wusbcore/security.c
> @@ -626,7 +626,7 @@ void wusbhc_gtk_rekey(struct wusbhc *wusbhc)
>                struct wusb_dev *wusb_dev;
>
>                wusb_dev = wusbhc->port[p].wusb_dev;
> -               if (!wusb_dev || !wusb_dev->usb_dev | !wusb_dev->usb_dev->authenticated)
> +               if (!wusb_dev || !wusb_dev->usb_dev || !wusb_dev->usb_dev->authenticated)
>                        continue;
>
>                usb_fill_control_urb(wusb_dev->set_gtk_urb, wusb_dev->usb_dev,
>

Hi Alexey,

This one is a logical 'or'... your changelog says 'and'!

-- 
Tom Spink
Douglas William Jerrold  - "The only athletic sport I ever mastered
was backgammon."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/